Matthew Poole and continuators on Ephesians 5:19

19 Speaking to your selves in psalms, and hymns, and spiritual songs , singing and making melody in your heart to the Lord .

In opposition to the vain chaff, and lewd talkativeness of drunkards over their Cups.

Gr. in your selves, i. e. among your selves, both in Church Assemblies, and Families.

Under these names he comprehends all manner of Singing to mutual Edification and God's Glory, the particular distinction of them is uncertain, but most take Psalms to be such as anciently were sung with Musical Instruments, Hymns such as contained onely matter of praise, spiritual Songs such as were of various matter, doctrinal, prophetical, historical, &c. see on Col. 3.16.

Not onely with your voice, but with inward affection, contrary to the guise of Hypocrites.

To the Glory of God, not for the pleasure of the sense, or for gain, &c.